Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix target layout fetching #16545

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 12, 2024

#16537 broke this, as cargo rustc cannot run against a virtual workspace, so it will always fail in such projects (like rust-analyzer itself). This brings back the plain rustc fallback,

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2024
@Veykril
Copy link
Member Author

Veykril commented Feb 12, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2024

📌 Commit a7641a8 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 12, 2024

⌛ Testing commit a7641a8 with merge 3770f73...

@bors
Copy link
Contributor

bors commented Feb 12, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3770f73 to master...

@bors bors merged commit 3770f73 into rust-lang:master Feb 12, 2024
11 checks passed
@Veykril Veykril deleted the fix-target-layout-fetch branch September 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants